Initial move to using twirl for template parsing. #217
Conversation
|
Test FAILed. |
| target/lib/scala-io-file.jar, | ||
| target/lib/templates.jar | ||
| target/lib/scala-io-core_2.11.jar, | ||
| target/lib/scala-io-file_2.11.jar, |
There was a problem hiding this comment.
The Scala.IO dependency is commented out, we probably can remove it here as well.
|
This passes tests on 2.11 on my machine, looking forward to a review! /cc @huitseeker |
|
Test PASSed. |
|
Test PASSed. |
| @@ -4,5 +4,7 @@ | |||
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.6"/> | |||
| <classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/> | |||
| <classpathentry kind="lib" path="target/lib/mockito-all-1.9.0.jar"/> | |||
| <classpathentry exported="true" kind="lib" path="target/lib/twirl-compiler.jar"/> | |||
There was a problem hiding this comment.
Not sure the 'exported' is interesting for tests ...
|
This LGTM ! |
Fixed tests that started failing under 2.11. * added a strategic `initialize` call before checking `.isAbstractClass`, since flags weren’t there yet * made the stub `play.mvc.Result` a proper public class (default visibility in Java is package private). The 2.11 compiler correctly failed those tests.
|
Test PASSed. |
|
This looks very good ! Templates look pruutty Next step : #216 |
|
@huitseeker, definitely... is there a ticket for that? |
Initial move to using twirl for template parsing.
Review, let's merge!
Initial work for moving off of Play dependencies and using twirl instead. Twirl is cross-compiled and will allow us to move freely on different Scala versions independent of Play.
Fixed tests for 2.11, see commit message.